Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Importing account from private key wasn't possible #185

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix: Importing account from private key wasn't possible #185

merged 1 commit into from
Dec 5, 2023

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Dec 5, 2023

Problem:

  1. Wasn't allowed to simply send a private key
  2. Encoding on file wasn't correct

@1yam 1yam requested a review from MHHukiewitz December 5, 2023 20:10
MHHukiewitz
MHHukiewitz approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 3a8e9fc into aleph-im:master Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1yam @MHHukiewitz